Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for documentation generator #3070

Merged
merged 2 commits into from
Aug 2, 2016
Merged

Conversation

oprypin
Copy link
Member

@oprypin oprypin commented Jul 31, 2016

Before/after:

Before/after

@asterite
Copy link
Member

asterite commented Aug 1, 2016

How can I reproduce this problem? I tried the link in File, using Chrome and it seems to be working well.

I wouldn't remove the tags, I would instruct the method not to generate them in the first place (just in case that regex removes more than it should)

@oprypin
Copy link
Member Author

oprypin commented Aug 1, 2016

@asterite Hmm that was in Firefox but somehow I can't full reproduce this today???
Anyway, at least the final bracket is cut off, in both Firefox and Chrome

About removing the tags - you know how there is that links = true / links: links flag passed around everywhere? Well, another flag would have to join it, which is a real mess and I think it's not worth bothering. At first I thought I could just turn this links = true into a html = false but there are instances where some HTML is needed but not links.

The regex can't remove more than it should because non-tag brackets must already be <``> at that point anyway.

@asterite
Copy link
Member

asterite commented Aug 2, 2016

I think links can be replaced with html. Where would be the place where links = false but html = true?

(we could just merge this, but lately I'm trying to justify all code changes and come up with the best "correct" solution for everything)

@oprypin
Copy link
Member Author

oprypin commented Aug 2, 2016

In Class Method Summary, HTML is there for colors but links are not present.

@asterite
Copy link
Member

asterite commented Aug 2, 2016

@BlaXpirit Oh, right... Well, for now it's much easier to just remove the tags in that place, so let's do that.

@asterite asterite merged commit 1cfff0d into crystal-lang:master Aug 2, 2016
@asterite asterite added this to the 0.19.0 milestone Aug 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants