-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Java 9 support #4111
Comments
This new exception is raised by Jigsaw when you attempt to make accessible the inaccessible elements of a module's classes. Unfortunately, since the exception doesn't exist on Java 8, there's no way to catch it (in code that needs to build on Java 8) except for this hack. This allows `jruby -e 1` to run properly on Java 9. This fixes part of #4111.
This new exception is raised by Jigsaw when you attempt to make accessible the inaccessible elements of a module's classes. Unfortunately, since the exception doesn't exist on Java 8, there's no way to catch it (in code that needs to build on Java 8) except for this hack. This allows `jruby -e 1` to run properly on Java 9. This fixes part of #4111.
"najs" hack - was thinking about approaching Java 8 support (in Java code) by doing a core sub-module but it gets complicated maintenance hell quickly. so your approach is probably the best it gets atm. on a related note maybe we shall at least consider dropping Java 7 for 9.2 does that sound reasonable (we could do much greater JI when compiling under 8) ? |
just seen #4112 ... so I guess Java 7 stays in the picture (for 9.2) than :( |
Following up here from #4558 Running JRuby 9.1.7.0 with a bunch of
(This adds opens for java.lang, java.security, java.util, and java.security.cert) |
Gem installation seems to fail because RubyZlib fails during installation
|
RubyZlib calls setAccessible on java.util.zip.CRC32 , so adding The following flags are what I'm using now to make progress testing on JRuby 9k + Java 9.
|
Do we have any updates on this? (I haven't yet installed Java 9; the GA release was announced a couple of weeks ago.) |
JRuby 9.1.14 will work properly on Java 9, albeit with some warnings for some actions. The examples here with The other day I ran JRuby 9.1.14 with Rails 5 on JDK9 and it was able to do everything properly without many warnings. I would say we support JDK9 well enough to close this issue. I will open a new issue for ongoing accessibility warnings, so we can aggregate what flags are needed and get them into the launchers (or find alternative ways that don't trigger warnings). |
Awesome — thank you!
…On Tue, Oct 31, 2017 at 1:51 PM Charles Oliver Nutter < ***@***.***> wrote:
Closed #4111 <#4111>.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4111 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAIC6mxjTxpLzt_KwidruKKnGg1R7ppVks5sx4hBgaJpZM4Jsfx0>
.
|
We have not yet started testing on Java 9, and there are certain to be some interesting challenges running alongside Jigsaw.
This is a catch-all bug to get Java 9 support working by JRuby 9.2.
Here's what we know is outstanding:
java.lang.reflect.InaccessibleObjectException
, a new exception in 9 that indicates we can't setAccessible JDK classes. (84b12e7 and 677ce03)The text was updated successfully, but these errors were encountered: