Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scidavis #17978

Closed
wants to merge 2 commits into from
Closed

Scidavis #17978

wants to merge 2 commits into from

Conversation

rardiol
Copy link
Contributor

@rardiol rardiol commented Aug 25, 2016

Motivation for this change
Things done
  • Tested using sandboxing
    (nix.useChroot on NixOS,
    or option build-use-chroot in nix.conf
    on non-NixOS)
  • Built on platform(s)
    • NixOS
    • OS X
    • Linux
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Python isn't working yet, it just SIGSEGVs as soon as python is selected as scripting language

@@ -0,0 +1,30 @@
{stdenv, fetchurl, qwt, gsl, qwtPlot3D, muparser, zlib, qt4, qmake4Hook, python2, python2Packages
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please don't pass in python2 as python2Packages already has the attribute python

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2016

is this finished already?

@rardiol
Copy link
Contributor Author

rardiol commented Oct 1, 2016

If by "finished" you mean the python problem being fixed then no.

@Mic92
Copy link
Member

Mic92 commented Oct 1, 2016

do you think this application would be useful without python support?


buildInputs = [
qwt gsl muparser qt4 zlib qmake4Hook qwtPlot3D
python2Packages.python python2Packages.sip python2Packages.pyqt4 #Support for python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you use python.withPackages to create a Python env where all modules can be found

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied from gnome-tweak-tool and now it SIGSEGV at startup:

{stdenv, fetchurl, qwt, gsl, qwtPlot3D, muparser, zlib, qt4, qmake4Hook, python2Packages
}:

let
  python = python2Packages.python.withPackages ( ps: with ps; [ sip pyqt4 ]); #Support for python
in stdenv.mkDerivation rec {
  version = "1.14";
  name = "scidavis-${version}";

  src = fetchurl {
    url = "mirror://sourceforge/project/scidavis/SciDAVis/${version}/scidavis-${version}.tar.gz";
    sha256 = "0904dfz0ijgqvx216wy7qic2hhnm0inkmwi9484d1517sb0bdz55";
  };

  qmakeFlags = "CONFIG+=python";

  installFlags = "INSTALL_ROOT=$(out)";

  postInstall = "mv $out/usr/* $out";

  buildInputs = [
     qwt gsl muparser qt4 zlib qmake4Hook qwtPlot3D
     python
  ];

  meta = with stdenv.lib; {
    homepage = http://scidavis.sourceforge.net/;
    description = "A free application for Scientific Data Analysis and Visualization";
    license = licenses.gpl2Plus;
    platforms = platforms.all;
  };
}

@rardiol
Copy link
Contributor Author

rardiol commented Oct 1, 2016

Yes, the default scripting language is working, so it's useful.

@Mic92
Copy link
Member

Mic92 commented Oct 5, 2016

do you want to disable python support if its not working?

@rardiol
Copy link
Contributor Author

rardiol commented Oct 5, 2016

I wanted a fairy to come and fix it for me, but looks like it's not happening. So yes, python support removed.


buildInputs = [
qwt gsl muparser qt4 zlib qmake4Hook qwtPlot3D
# python2Packages.python python2Packages.sip python2Packages.pyqt4 #Support for python
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use python.withPackages( ps; with ps; [ pyqt4 sip ])

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely that's enough since any shebangs pointing to python will then use environment

@FRidh
Copy link
Member

FRidh commented Jan 2, 2017

This has been open for quite a while. @rardiol, please open a new PR if you want to get this in.

@FRidh FRidh closed this Jan 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants