Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Add CExt test for ruby-argon2 #4058

Merged
merged 1 commit into from
Aug 10, 2016

Conversation

lxp
Copy link
Contributor

@lxp lxp commented Aug 9, 2016

['nokogiri', [], ['nokogiri']]
].each do |gem_name, dependencies, libs|
['nokogiri', [], ['nokogiri']],
['ruby-argon2', [], ['ruby-argon2'], {'GEM_HOME' => "#{ENV['GEM_HOME']}/bundler/gems/ruby-argon2-afe6d65e37c6", 'TEST_CHECKS' => '1'}]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should GEM_HOME be set to a specific gem like that?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed jt cextc so this should no longer be needed only
['ruby-argon2', [], ['ruby-argon2']],.
For TEST_CHECK, maybe the default can be 1 in the test harness?
Configuration is always easier to keep closer to the source :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a way to specify the path to the argon2 dir in the test pack though, probably can be an extra argument in this list.

@pitr-ch
Copy link
Member

pitr-ch commented Aug 9, 2016

jruby/jruby-truffle-gem-test-pack#1 looks good

@lxp lxp force-pushed the add-cexts-test-ruby-argon2 branch from d2ceb6d to 98a181e Compare August 10, 2016 09:22
@eregon eregon merged commit 625dbd3 into jruby:master Aug 10, 2016
@enebo enebo modified the milestone: truffle-dev Aug 26, 2016
@enebo enebo added this to the Invalid or Duplicate milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants