Fixed #3115: Object.setter macro iterates over names twice

crystal-lang · Aug 8, 2016 · 349c90b · 349c90b
1 parent 5bd77e8
commit 349c90b
Showing 1 changed file with 11 additions and 13 deletions.
diff --git a/src/object.cr b/src/object.cr
@@ -584,21 +584,19 @@ class Object
   # ```
   macro setter(*names)
     {% for name in names %}
-      {% for name in names %}
-        {% if name.is_a?(TypeDeclaration) %}
-          @{{name}}
+      {% if name.is_a?(TypeDeclaration) %}
+        @{{name}}
 
-          def {{name.var.id}}=(@{{name.var.id}} : {{name.type}})
-          end
-        {% elsif name.is_a?(Assign) %}
-          @{{name}}
+        def {{name.var.id}}=(@{{name.var.id}} : {{name.type}})
+        end
+      {% elsif name.is_a?(Assign) %}
+        @{{name}}
 
-          def {{name.target.id}}=(@{{name.target.id}})
-          end
-        {% else %}
-          def {{name.id}}=(@{{name.id}})
-          end
-        {% end %}
+        def {{name.target.id}}=(@{{name.target.id}})
+        end
+      {% else %}
+        def {{name.id}}=(@{{name.id}})
+        end
       {% end %}
     {% end %}
   end