Reimplement NamedTuble#fetch(String) using a Trie #3174
Closed
+33
−2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of comparing each string key one by one, build a Prefix Tree at compile-time and make a single comparison per char. This improves performance by 16x on large named tuples and about 1.5x on smaller ones.
Large benchmark: https://gist.github.com/lbguilherme/c7249c408d2a226bdbb6892dda5e9ab2
Small benchmark: https://gist.github.com/lbguilherme/7dba63104c4b44d3adcd5bcc9f9d7c20
See #3143 and #2966