Better sockets and related stuff support #4093
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 19, 2016
etehtsea
force-pushed
the
socket-next
branch
7 times, most recently
from
562910e
to
48bab0a
Compare
Remove (un)pack_sockaddr specs from excludes
Return :wait_readable instead of IO::WaitReadable
This is based on specs created by @yorickpeterse for the rubysl/rubysl-socket move to a pure-ruby socket lib. Among the changes thusfar: * Many improvements to Addrinfo, including leveraging the JDK APIs better and having less state. More address types work correctly now. * Socket now handles more types of sockets, including servers. * Improvements to addressing behavior across all socket types. * In-progress refactoring of socket classes to be reusable from Socket grab-bag. At the moment there are around 565 specs tagged.
Also tested using specs from ruby/spec#287
Passes specs in rubysl-socket.
Also cleanup it and use RubySocket underneath
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on https://github.com/jruby/jruby/tree/ruby-2.3+socket
Opening WIP pull request in order to anyone could keep track its progress.
Every commit is tested using https://github.com/ruby/spec
See related PRs:
ruby/spec#279
ruby/spec#280
ruby/spec#281
ruby/spec#283
ruby/spec#284
ruby/spec#286
ruby/spec#287
ruby/spec#290