-
-
Notifications
You must be signed in to change notification settings - Fork 925
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null value getting into packed array #4080
Comments
Ok, the null may be coming via Java integration. The logic in AR-JDBC treats the incoming nested array as a Java |
@kares It looks like you did a bunch of work with |
there's special cases for some array type coercion to speed things up (a lot as array reflection is still slow on Java 8). did switch from |
@kares Ok. I'm still trying to figure out what has changed, though. An array like |
@kares FWIW it's easy to reproduce with the instructions about, and we can't release until we figure it out :-) |
I found the issue. There's a piece of code in arjdbc that does I have submitted a trivial fix for this in jruby/activerecord-jdbc-adapter#740 and @kares will verify it and cut a release tomorrow. @donv If you can test my patch now, that would be great. Hopefully you will at least test it after arjdbc release, so we can verify things are working now :-) |
This is not a 9.1.3.0 fix so I've moved it to non-release. @kares Should we create another bug in arjdbc to track this or is the PR enough? |
@headius did the change and released AR-JDBC 1.3.21 to play nicely with jruby-head and next release |
As @donv reported on #4020, there's a null getting into activerecord-jdbc. Here's the reproduction steps with Rails 4.2:
The final db:migrate blows up because of the null.
Here's the trace on my system:
And it turns out the reproduction is simple:
The inner array constructed in this case is a packed two-element array with the first element null. It should never be null, so something's not right here.
The text was updated successfully, but these errors were encountered: