no need to leak a handle if we control the module

mojolicious · Aug 16, 2016 · a2700bd · a2700bd
1 parent 77aa8d7
commit a2700bd
Showing 1 changed file with 4 additions and 6 deletions.
diff --git a/lib/Mojo/Util.pm b/lib/Mojo/Util.pm
@@ -32,13 +32,11 @@ use constant {
 # To generate a new HTML entity table run this command
 # perl examples/entities.pl
 my %ENTITIES;
-{
-  local $.;
-  for my $line (split "\n", join('', <DATA>)) {
-    next unless $line =~ /^(\S+)\s+U\+(\S+)(?:\s+U\+(\S+))?/;
-    $ENTITIES{$1} = defined $3 ? (chr(hex $2) . chr(hex $3)) : chr(hex $2);
-  }
+for my $line (split "\n", join('', <DATA>)) {
+  next unless $line =~ /^(\S+)\s+U\+(\S+)(?:\s+U\+(\S+))?/;
+  $ENTITIES{$1} = defined $3 ? (chr(hex $2) . chr(hex $3)) : chr(hex $2);
 }
+close DATA;
 
 # Characters that should be escaped in XML
 my %XML = (