listing: Guess the lexer from its contents if the file name is unknown to pygments. #2454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am slightly worried about this one because, well, what happens if pygments guesses wrong? TextLexer at least is never actively broken :-) Anyway, merging, we can always iterate! |
|
Could you add a one-liner to the features section in CHANGES.txt and add yourself to authors if you are not there? Thanks! |
xuhdev
force-pushed
the
listing-guess-lexer
branch
from
703d8e4
to
194c7ac
Compare
|
Thanks, done! If we eventually want to remove the guess part, maybe the best thing is to allow users to manually select a lexer. |
|
Yeah, we can always improve stuff. Thanks for the code! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.