Update Pygal chart options #2430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "css": directives.unchanged, | ||
| # "defs": directives.unchanged, |
There was a problem hiding this comment.
I thought not to include this option because it should receive a multiline value and it is kind of hard to write in a rst directive. But it could be accomplished using '\n' and spaces. So it can be included after all. Should I provide another pull request?
There was a problem hiding this comment.
If you can get it to work, you can just push one more commit to your fork with this uncommented.
|
Also, please add a one-liner in CHANGES and yourself to AUTHORS if you are not already there :-) |
|
One more housekeeping request, it looks like your commit was misattributed. Please add the e-mail address you used (pronus dot io) for this commit to your GitHub profile so your commits will appear as yours. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few new Pygal 2.2.3 options that could be used in chart directive.