crane-gps-watch: init at 20160308 #17877
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| sha256 = "0ji50yg85a114pdvw8k5jgfxq312frlxq67bazfaws9mkhnkpi9v"; | ||
| }; | ||
|
|
||
| meta = { |
There was a problem hiding this comment.
Please consider adding yourself as the maintainer.
merged upstream
|
Added myself as maintainer in the package and in lib/maintainers.nix. |
| }; | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = "https://www.github.com/mru00/crane_gps_watch"; |
There was a problem hiding this comment.
Equivalently, inherit (src.meta) homepage
|
Added a few more notes. When they have been addressed, please rebase and squash the commits into one. |
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "crane-gps-watch-${version}"; | ||
| version = "221f99dc2925a07658f7b6e01789ced1a18cc08c"; |
There was a problem hiding this comment.
Versions ought to satisfy new > old, so ISO 8601 dates are a better choice for vcs checkouts.
|
Please squash into a single commit. |
|
I changed the version number. There is a python2 script (gps_watch_monitor.py), which requires vte with python support and pygtk - which does not work at the moment for that reason. From e4b07527ab892ce5d362cc2798bdab941c57f2a9 Mon Sep 17 00:00:00 2001
From: Edd Baxter <pieceredd@gmail.com>
Date: Sun, 21 Aug 2016 01:39:03 +0100
Subject: [PATCH] crane-gps-watch: init at 2016-03-08
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Signed-off-by: Jörg Thalheim <joerg@higgsboson.tk>
---
lib/maintainers.nix | 1 +
pkgs/applications/misc/crane-gps-watch/default.nix | 20 ++++++++++++++++++++
pkgs/top-level/all-packages.nix | 2 ++
3 files changed, 23 insertions(+)
create mode 100644 pkgs/applications/misc/crane-gps-watch/default.nix
diff --git a/lib/maintainers.nix b/lib/maintainers.nix
index 08d6c8a..a2790c2 100644
--- a/lib/maintainers.nix
+++ b/lib/maintainers.nix
@@ -12,6 +12,7 @@
abbradar = "Nikolay Amiantov <ab@fmap.me>";
aboseley = "Adam Boseley <adam.boseley@gmail.com>";
abuibrahim = "Ruslan Babayev <ruslan@babayev.com>";
+ AcouBass = "Edd Baxter <pieceredd@gmail.com>";
acowley = "Anthony Cowley <acowley@gmail.com>";
adev = "Adrien Devresse <adev@adev.name>";
Adjective-Object = "Maxwell Huang-Hobbs <mhuan13@gmail.com>";
diff --git a/pkgs/applications/misc/crane-gps-watch/default.nix b/pkgs/applications/misc/crane-gps-watch/default.nix
new file mode 100644
index 0000000..d637478
--- /dev/null
+++ b/pkgs/applications/misc/crane-gps-watch/default.nix
@@ -0,0 +1,20 @@
+{ stdenv, fetchFromGitHub }:
+
+stdenv.mkDerivation rec {
+ name = "crane-gps-watch-${version}";
+ version = "2016-03-08";
+ src = fetchFromGitHub {
+ owner = "mru00";
+ repo = "crane_gps_watch";
+ rev = "221f99dc2925a07658f7b6e01789ced1a18cc08c";
+ sha256 = "0ji50yg85a114pdvw8k5jgfxq312frlxq67bazfaws9mkhnkpi9v";
+ };
+
+ meta = with stdenv.lib; {
+ inherit (src.meta) homepage;
+ description = "Crane GPS Watch client";
+ license = stdenv.lib.licenses.gpl3;
+ maintainers = [ maintainers.AcouBass ];
+ platforms = platforms.linux;
+ };
+}
diff --git a/pkgs/top-level/all-packages.nix b/pkgs/top-level/all-packages.nix
index 5132a67..92ffc3c 100644
--- a/pkgs/top-level/all-packages.nix
+++ b/pkgs/top-level/all-packages.nix
@@ -748,6 +748,8 @@ in
cpulimit = callPackage ../tools/misc/cpulimit { };
+ crane-gps-watch = callPackage ../applications/misc/crane-gps-watch { };
+
contacts = callPackage ../tools/misc/contacts { };
coturn = callPackage ../servers/coturn { };
--
2.10.0
|
|
@AcouBass ping? |
|
Closing as abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New pkg - small piece of software for creating .gpx files from various GPS watches.
Things done
(nix.useChroot on NixOS,
or option
build-use-chrootinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)