Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Socket branch partial merge #4086

Closed
wants to merge 9 commits into from

Conversation

etehtsea
Copy link
Contributor

I propose to merge commits from ruby-2.3+socket branch that don't depend from each other and still apply cleanly.

The JDK socket classes do both bind and listen at once and do not
expose a way to change the backlog after that. To work around
this, I reflectively attempt to access the class in which they
bind the native listen(2) function. If I'm able to use it, we will
set the backlog. If I'm not, TCPServer#listen remains mostly a
no-op.

Note that a strategy like RubySocket, where we defer the creation
of the actual socket, might work here...but that has not yet been
proven out, and subsequent calls to listen would not work.
@etehtsea
Copy link
Contributor Author

etehtsea commented Aug 19, 2016

There is better way how to merge this in than "get everything that still apply cleanly".
Superseded by #4093

@etehtsea etehtsea closed this Aug 19, 2016
@enebo enebo modified the milestone: Non-Release Aug 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants