Socket refactors #3076
Merged
Socket refactors #3076
+393
−148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Harmonize coding styles, variables naming, and methods called across the different classes. Write missing documentation. Add missing `open` (with arguments) and `accept?` methods to UNIXServer so it's on par with TCPServer. Disable ability to select a protocol for `UDPSocket.pair` since the general methods (`new` and `open`) don't allow it, and OSes don't support any other protocol than the default `IPPROTO_IP` (0). Avoid to leak a file descriptor when creating a UNIXSocket or UNIXServer when the path is too long than supported by the OS. Also raises ArgumentError instead of Exception.
UNIXServer shouldn't remove the existing socket path if it already exists, but let the OS report an error and raise, instead of hijacking existing servers listening on the socket. This allows allows to use abstract socket addresses (containing null bytes). fixes crystal-lang#3068
|
@ysbaddaden Thank you so much for this! Docs + cleaned up code = win! :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I extracted the Socket documentation and code harmonization from #2829 along with improvements to UNIXServer and UNIXSocket so they are on par with TCPServer and TCPSocket, and a few more specs. I also fixed UNIXServer deleting the existing socket before binding the socket from #3068.