Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 945e20a30d68
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: fe34564c4497
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Aug 6, 2016

  1. Add line numbers before adding LINE and CALL trace instructions

    This makes it so that stack traces gathered inside the trace instruction
    have accurate line numbers (and is especially important because some
    debuggers use line numbers from the stack trace, rather than the ones
    received by set_trace_func).
    
    Issue #4051
    ivoanjo committed Aug 6, 2016
    Copy the full SHA
    3948b0d View commit details
  2. Add FIXME and link to issue 4051 to RETURN and END trace instructions

    Unlike the LINE and CALL trace instructions, currently the parser does
    not supply line numbers for RETURN and END trace instructions.
    
    This is worked around by by the TraceInstr by computing line numbers
    dynamically, rather than statically, but the same approach cannot be
    applied to line number instructions, which means that line numbers in
    stack traces generated inside the trace function will not be correct.
    
    As the fix seems to be quite hard, I think it's important to document
    this bug.
    
    Issue #4051
    ivoanjo committed Aug 6, 2016
    Copy the full SHA
    ca33dd0 View commit details

Commits on Aug 8, 2016

  1. Merge pull request #4052 from ivoanjo/partially-fix-set-trace-func-li…

    …ne-numbers
    
    Partially fix set_trace_func line numbers
    enebo authored Aug 8, 2016
    Copy the full SHA
    fe34564 View commit details
Loading