Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: PDLPorters/pdl
base: 2bd898200631
Choose a base ref
...
head repository: PDLPorters/pdl
compare: f4745a030e34
Choose a head ref
  • 11 commits
  • 13 files changed
  • 4 contributors

Commits on Aug 22, 2016

  1. 64 bit fix (bug #421)

    @d-lamb
    Craig DeForest authored and d-lamb committed Aug 22, 2016
    Copy the full SHA
    62ea1c1 View commit details
    Browse the repository at this point in the history

  2. initial attempt to include BAD value propagation. No tests yet.

    @d-lamb
    Craig DeForest authored and d-lamb committed Aug 22, 2016
    Copy the full SHA
    a516de7 View commit details
    Browse the repository at this point in the history

  3. remove extraneous test from pdlcore.c.PL; add BAD value tests to cons… 

    …tructor.t
    @d-lamb
    Craig DeForest authored and d-lamb committed Aug 22, 2016
    Copy the full SHA
    52b1393 View commit details
    Browse the repository at this point in the history

  4. Add documentation to Core.pm POD; fix test count in constructor.t.

    @d-lamb
    Craig DeForest authored and d-lamb committed Aug 22, 2016
    Copy the full SHA
    55f73fe View commit details
    Browse the repository at this point in the history

  5. fix skip count for no-badvals case

    @d-lamb
    Craig DeForest authored and d-lamb committed Aug 22, 2016
    Copy the full SHA
    ca2cd65 View commit details
    Browse the repository at this point in the history

  6. Prevent segfault when qsort etc called with a scalar argument 

    If a user mistakenly passed a perl scalar argument to qsort and
its ilk, the SV would be mistaken for a piddle and passed to
the underlying generic_qsort etc routines. Not surprisingly,
those routine's array index tricks would cause a segfault. This
commit causes qsort, qsorti, qsortvec, and qsortveci to barf
if an argument is passed with incorrect dimensions.

Some care is taken to allow trivial sorts.

2 tests for each routine have been added, and some existing
tests labeled.
    @d-lamb
    d-lamb committed Aug 22, 2016
    Copy the full SHA
    2fb35ea View commit details
    Browse the repository at this point in the history

  7. Change pdl_barf to PDL->pdl_barf in ufunc.pd. 

    Hopefully this will compile on Strawberry. Not sure why the original
worked OK on my Mac w/ clang.
    @d-lamb
    d-lamb committed Aug 22, 2016
    Copy the full SHA
    acfc5cd View commit details
    Browse the repository at this point in the history

  8. Fixes badval propagation to support all badval configurations 

    The changes in <#188> broke the
build for all cases of `BADVAL_USENAN` xor `BADVAL_PER_PDL`.

This was because the checking for badvalues when copying in
`pdl_kludge_copy_*` did not take into account these variations in
accessing and setting the badvalue.

For example, a simple comparison using `==` is not valid when NaN
values are being compared. Here we need to use `!finite(...)` to make
the comparison if the type can use NaN values.
    @zmughal @d-lamb
    zmughal authored and d-lamb committed Aug 22, 2016
    Copy the full SHA
    c027278 View commit details
    Browse the repository at this point in the history

  9. Add clarifying documentation and tests for svd(). 

    The example in the docs was using the matrix v directly instead of
the transpose.  Doesn't matter for 2x2 matrices, but does for larger.
Hopefully this clears things up.

I also added some tests for svd: square matrices, and rectangular
matrices where m>n and m<n.
    @d-lamb
    d-lamb committed Aug 22, 2016
    Copy the full SHA
    e699f42 View commit details
    Browse the repository at this point in the history

  10. Heavily comment svd.c. 

    Some comments taken from Nash (1990), some are my own to aid in
understanding this algorithm.
    @d-lamb
    d-lamb committed Aug 22, 2016
    Copy the full SHA
    d264359 View commit details
    Browse the repository at this point in the history

  11. Allow wcols to obey FORMAT option. 

    The code to determine whether the output size agreed with the
format string size was only activated when the format string was
input as the first argument, not in the options hash. This change
activates it for both cases.

Added some tests as well.
    @d-lamb
    d-lamb committed Aug 22, 2016
    Copy the full SHA
    f4745a0 View commit details
    Browse the repository at this point in the history