Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 81bfe6a11704
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ddbcb76e450b
Choose a head ref
  • 11 commits
  • 8 files changed
  • 1 contributor

Commits on Aug 26, 2016

  1. [Truffle] Sped up making a RepeatingRope from a RopeBuffer.

    MRI and JRuby both use this approach of expanding the copied region. We must have just missed it when doing the initial implementation.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    9efb699 View commit details
  2. [Truffle] Added a faster path for fetching the bytes of a RepeatingRo…

    …pe whose child has its bytes populated.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    a6c7d33 View commit details
  3. [Truffle] Added a faster path for fetching the bytes of a SubstringRo…

    …pe whose child has its bytes populated.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    10726d2 View commit details
  4. Copy the full SHA
    b5c1c39 View commit details
  5. Copy the full SHA
    732dfac View commit details
  6. [Truffle] Fixed String#+ for RopeBuffers.

    Without an explicit dup of the RopeBuffer, we'd mutate the receiver's bytes.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    faa08ec View commit details
  7. [Truffle] Fixed String#bytesize for RopeBuffers.

    While we could fix this by allowing Rope#byteLength to be overrideable, we don't want to make that call virtual.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    441873b View commit details
  8. [Truffle] Fixed String#replace for RopeBuffers.

    Without duping the original RopeBuffer any modifications to the resulting string will also be visible in the source string.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    fbcfbdb View commit details
  9. [Truffle] Simplified the guard checking if a substring would simply b…

    …e the same as its child.
    
    The old calculation took the offset into account and I think this was a bug. A non-zero offset would trivially ensure the substring and its child were not the same. Since the byte length of the substring is bounded by the byte length of the child (enforced at a higher level), we can reduce the check to simply seeing if the substring has the same byte length as the child.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    ce464e4 View commit details
  10. [Truffle] Avoid reprocessing a complex rope when getting the bytes fo…

    …r a RepeatingRope by flattening its child first.
    nirvdrum committed Aug 26, 2016
    Copy the full SHA
    1703f16 View commit details
  11. Copy the full SHA
    ddbcb76 View commit details
Loading