Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Truffle] Polyglot eval io exception #4109

Closed
wants to merge 2 commits into from
Closed

[Truffle] Polyglot eval io exception #4109

wants to merge 2 commits into from

Conversation

jtulach
Copy link
Contributor

@jtulach jtulach commented Aug 24, 2016

Truffle's PolyglotEngine.eval no longer throws IOException after oracle/graal@5e141bd

This change adjust JRuby code to be compilable with both versions. The old one that throws IOException and the new one which doesn't.

…l that throws IOException as well as the new one which doesn't do so.
@jtulach jtulach changed the base branch from master to truffle-head August 24, 2016 14:18
@enebo enebo changed the title Polyglot eval io exception [Truffle] Polyglot eval io exception Aug 24, 2016
@jtulach
Copy link
Contributor Author

jtulach commented Aug 25, 2016

Mergeable? Or is there a problem that I am supposed to fix?

@eregon
Copy link
Member

eregon commented Aug 25, 2016

@jtulach I just did the change yesterday to use latest truffle: 3f5e725.
I think that commit is much cleaner and also more correct.
I'll merge it when we update Truffle.
Thank you for the change, but I prefer not merging such a hack.

@eregon eregon closed this Aug 25, 2016
@jtulach
Copy link
Contributor Author

jtulach commented Aug 25, 2016

C'mon it is not a hack: it is a transition state. Anyway I am trying your
latest commits, maybe they'll be sufficient OK.

2016-08-25 11:49 GMT+02:00 Benoit Daloze notifications@github.com:

@jtulach https://github.com/jtulach I just did the change yesterday to
use latest truffle: 3f5e725
3f5e725
.
I think that commit is much cleaner and also more correct.
I'll merge it when we update Truffle.
Thank you for the change, but I prefer not merging such a hack.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4109 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/ABwc9o5eG4EEacG5h6TQUL8fnFsK9SVYks5qjWUVgaJpZM4JsDgx
.

@enebo enebo added this to the truffle-dev milestone Aug 26, 2016
@enebo enebo added this to the Invalid or Duplicate milestone Dec 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants