Skip to content

Commit

Permalink
Browse files Browse the repository at this point in the history
Don’t store timestamp in github_deploy (#2470)
Rationale: the Git repo will *never* be clean, because the state file
will be created after we push everything.

Moving it before we commit to the source branch means we’d store
timestamp of last deployment attempt.
  • Loading branch information
Kwpolska authored and ralsina committed Aug 24, 2016
1 parent 1591e27 commit e705bf9
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions nikola/plugins/command/github_deploy.py
Expand Up @@ -27,7 +27,6 @@
"""Deploy site to GitHub Pages."""

from __future__ import print_function
from datetime import datetime
import os
import subprocess
from textwrap import dedent
Expand Down Expand Up @@ -166,7 +165,3 @@ def _commit_and_push(self, commit_first_line):
return e.args[0]

self.logger.info("Successful deployment")

# Store timestamp of successful deployment
new_deploy = datetime.utcnow()
self.site.state.set('last_deploy', new_deploy.isoformat())

0 comments on commit e705bf9

Please sign in to comment.