👍 from me. @asterite what was the intended behavior here? Do we want to support an enum like

enum Foo
  Bar
  BAR
end

here or should parse just return the first match regardless of any casing?

I think parse should be case-insensitive, I can't remember why it uses camelcase, maybe to parse "foo_bar" into "FooBar", but that probably doesn't make sense.

I would discourage enums with Bar and BAR as members. We could even have the compiler give an error in that case because it's pretty confusing (if the downcased names conflict). What do you think?

Fine with me if we prefer the explicit names over the autogenerated ones in the case of flag enums, that is just silently don't autogenerate anything if it would conflict.

@asteritesnake_case is used quite often so I'd be 👍 for keeping the conversion as is.

My use case was for converting something like: "TASK_RUNNING" to "Running"
of an enum "TaskState".

I added a method to my enum to strip a prefix "TASK_", downcase and then
parse.

Anyway, I just wanted to correct the docs if they were broken. Changing the
code would be ok too.
On Mon, Aug 8, 2016 at 3:25 PM Sijawusz Pur Rahnama <
notifications@github.com> wrote:

@asterite https://github.com/asteritesnake_case is used quite often so
I'd be 👍 for keeping the conversion as is.

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#3108 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AACpPR-OzhLFGiIsR7wu9UjyV_POQ4hXks5qd57XgaJpZM4JefEH
.