-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
run standard library specs in release mode on travis #3144
Conversation
Looks like it actually exposes a bug: https://travis-ci.org/crystal-lang/crystal/jobs/151792684 |
On my machine |
Actually, they fail with the current compiler, but not in the next one. I'll later try to see if it's an LLVM bug or there's a bug in the codegen. |
When I discovered this on |
Bump on this, sha1 specs still fail in release mode on master which is super concerning to me. Some of the bytes still get corrupted, for example:
|
#triage |
Sure why not, I hope memory consumption is low enough still. |
Release mode doesn't pass for me, i'm trying to work out why right now. First guess from gdb is codegen is somehow passing uninitialized memory as the closure to a proc. |
If this is rebased on master it should pass travis. |
@jhass is this PR still relevant? |
Closing. We moved to Circle. |
This should catch codegen bugs that only appear after LLVM optimizations.