Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

run standard library specs in release mode on travis #3144

Closed
wants to merge 1 commit into from

Conversation

jhass
Copy link
Member

@jhass jhass commented Aug 12, 2016

This should catch codegen bugs that only appear after LLVM optimizations.

@jhass
Copy link
Member Author

jhass commented Aug 12, 2016

Looks like it actually exposes a bug: https://travis-ci.org/crystal-lang/crystal/jobs/151792684

@asterite
Copy link
Member

On my machine digest/sha1 specs fail with --release, I have no idea why

@asterite
Copy link
Member

Actually, they fail with the current compiler, but not in the next one. I'll later try to see if it's an LLVM bug or there's a bug in the codegen.

@RX14
Copy link
Member

RX14 commented Aug 12, 2016

When I discovered this on 0.18.7, digest/sha1 and one process spec were failing. The sha1 spec failing is quite concerning to me...

@RX14
Copy link
Member

RX14 commented Dec 9, 2016

Bump on this, sha1 specs still fail in release mode on master which is super concerning to me.

Some of the bytes still get corrupted, for example:

  4) Digest::SHA1 does digest for "The quick brown fox jumps over the lazy dog"
     Failure/Error: bytes.to_slice.hexstring.should eq(hexdigest)

       expected: "2fd4e1c67a2d28fced849ee1bb76e7391b93eb12"
            got: "2fd480c67a2d28fced842be1bb76e7391b931212"

@miketheman
Copy link
Contributor

#triage
@jhass Is it worth rebasing this against master and having Travis try again? I tried today with Crystal 0.23.0+35 [890ab45bf] (2017-08-04) LLVM 4.0.1 - and it passed locally.

@jhass
Copy link
Member Author

jhass commented Aug 4, 2017

Sure why not, I hope memory consumption is low enough still.

@RX14
Copy link
Member

RX14 commented Aug 4, 2017

Release mode doesn't pass for me, i'm trying to work out why right now. First guess from gdb is codegen is somehow passing uninitialized memory as the closure to a proc.

@RX14
Copy link
Member

RX14 commented Aug 4, 2017

If this is rebased on master it should pass travis.

@straight-shoota
Copy link
Member

@jhass is this PR still relevant?

@ysbaddaden
Copy link
Contributor

Closing. We moved to Circle.

@ysbaddaden ysbaddaden closed this Apr 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants