Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xflux-gui: 2016-09-21 -> 1.1.10 #29015

Merged
merged 1 commit into from Oct 1, 2017
Merged

xflux-gui: 2016-09-21 -> 1.1.10 #29015

merged 1 commit into from Oct 1, 2017

Conversation

aske
Copy link
Member

@aske aske commented Sep 5, 2017

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Sep 5, 2017

Do I need a service/desktop environment to use fluxgui?

$ /nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/bin/fluxgui
Failed to contact configuration server; the most common cause is a missing or misconfigured D-Bus session bus daemon. See http://projects.gnome.org/gconf/ for information. (Details -  1: GetIOR failed: GDBus.Error:org.freedesktop.DBus.Error.ServiceUnknown: The name org.gnome.GConf was not provided by any .service files)
Critical error. Exiting.
Traceback (most recent call last):
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/bin/...fluxgui-wrapped-wrapped-wrapped", line 22, in <module>
    main()
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/lib/python2.7/site-packages/fluxgui/fluxapp.py", line 213, in main
    try:
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/lib/python2.7/site-packages/fluxgui/fluxapp.py", line 28, in __init__
    print "Critical error. Exiting."
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/lib/python2.7/site-packages/fluxgui/fluxapp.py", line 43, in exit
    try:
AttributeError: 'FluxGUI' object has no attribute 'xflux_controller'
Exception AttributeError: AttributeError("'FluxGUI' object has no attribute 'xflux_controller'",) in <bound method FluxGUI.__del__ of <fluxgui.fluxapp.FluxGUI object at 0x7fde31009990>> ignored

@joachifm
Copy link
Contributor

cc maintainer @sheenobu

@sheenobu
Copy link
Contributor

I don't think you need a desktop environment for this. The error looks unrelated but I'm checking it out now.

@sheenobu
Copy link
Contributor

@Mic92 yes you'll need gconf and maybe dbus to run the fluxgui. Not the full gnome environment, though.

This part:

Traceback (most recent call last):
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/bin/...fluxgui-wrapped-wrapped-wrapped", line 22, in <module>
    main()
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/lib/python2.7/site-packages/fluxgui/fluxapp.py", line 213, in main
    try:
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/lib/python2.7/site-packages/fluxgui/fluxapp.py", line 28, in __init__
    print "Critical error. Exiting."
  File "/nix/store/ydagh41zyqadj1idch4vhhn7kqfnyjcm-xflux-gui-1.1.10/lib/python2.7/site-packages/fluxgui/fluxapp.py", line 43, in exit
    try:
AttributeError: 'FluxGUI' object has no attribute 'xflux_controller'
Exception AttributeError: AttributeError("'FluxGUI' object has no attribute 'xflux_controller'",) in <bound method FluxGUI.__del__ of <fluxgui.fluxapp.FluxGUI object at 0x7fde31009990>> ignored

is just bad cleanup code in the fluxgui code.

@orivej orivej merged commit 2daad2f into NixOS:master Oct 1, 2017
@orivej
Copy link
Contributor

orivej commented Oct 1, 2017

Thanks! You shouldn't replace pythonPackages with python2Packages in derivations. If you want to be explicit, set pythonPackages = python2Packages in all-packages.nix, although there is no need for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants