Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hyper: 1.3.3 -> 1.4.3 #29018

Merged
merged 1 commit into from Sep 5, 2017
Merged

hyper: 1.3.3 -> 1.4.3 #29018

merged 1 commit into from Sep 5, 2017

Conversation

jlesquembre
Copy link
Member

Motivation for this change

hyper: 1.3.3 -> 1.4.3

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Mic92
Mic92 reviewed Sep 5, 2017
View reviewed changes
pkgs/applications/misc/hyper/default.nix
name = "hyper-${version}";
src = fetchurl {
url = "https://github.com/zeit/hyper/releases/download/${version}/hyper_${version}.deb";
sha256 = "1i68n77yv1g4dfx4xfmcb06mfpwhf0gnb3wmldg2gxkhs0fn19zg";
url = "https://github.com/zeit/hyper/releases/download/${version}/hyper_${version}_amd64.deb";
Copy link
Member

@Mic92 Mic92 Sep 5, 2017 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not running on 32bit on then, right?
This is ok, but platforms should be also updated:

- platforms = [ "i686-linux" "x86_64-linux" ];
+ platforms = [ "x86_64-linux" ];

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right, on the last hyper release, only 64bit is supported.

@Mic92 Mic92 merged commit 9a9629e into NixOS:master Sep 5, 2017
@jlesquembre jlesquembre deleted the hyper branch October 3, 2017 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jlesquembre @Mic92