containerd: 0.2.9 -> 1.0.1 #29300
Merged
containerd: 0.2.9 -> 1.0.1 #29300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vdemeester, thanks for your PR! By analyzing the history of the files in this pull request, we identified @NeQuissimus, @joachifm and @offlinehacker to be potential reviewers. |
vdemeester
force-pushed
the
update-containerd-1
branch
from
818922a
to
a51ae8b
Compare
|
Is there a reason we should not wait for the final release? |
|
@Mic92 no reason really 馃懠 I did update it on my nixpkgs to be able to use that verison on my laptop but I'm fine holding this PR until the 1.0.0 get released 馃槈 |
vdemeester
changed the title
vdemeester
force-pushed
the
update-containerd-1
branch
from
a51ae8b
to
b397d81
Compare
mikefaille
reviewed
Nov 18, 2017
|
|
||
| preBuild = '' | ||
| ln -s $(pwd) vendor/src/github.com/containerd/containerd | ||
| export BUILDTAGS="no_btrfs" |
There was a problem hiding this comment.
I actually use docker on btrfs. At least, can you create an option ?
vdemeester
force-pushed
the
update-containerd-1
branch
from
b397d81
to
6cfa9cc
Compare
|
Update to 1.0.0 as it's now released https://github.com/containerd/containerd/releases/tag/v1.0.0 |
vdemeester
force-pushed
the
update-containerd-1
branch
from
6cfa9cc
to
d96de48
Compare
|
@Mic92 @NeQuissimus @mikefaille updated, now build with btrfs if available. I'll follow-up to add a module (脿-la-docker) too 馃懠 |
NeQuissimus
approved these changes
Jan 16, 2018
Update containerd to its latest release ! Signed-off-by: Vincent Demeester <vincent@sbr.pm>
vdemeester
force-pushed
the
update-containerd-1
branch
from
d96de48
to
ef07118
Compare
|
Updated to 1.0.1 馃懠 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update containerd to its latest beta. (Probably would need tests like the docker one 馃懠 I'll look into it)
Signed-off-by: Vincent Demeester vincent@sbr.pm
Motivation for this change
The diff between containerd 0.2.x and 1.0.0 is huge (1.x is way more feature complete). Also, fixing
containerd --versionon 1.x 馃懠Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)