Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wip] jupyter_console: 5.0.0 -> 5.1.0 #29303

Closed
wants to merge 1 commit into from
Closed

[wip] jupyter_console: 5.0.0 -> 5.1.0 #29303

wants to merge 1 commit into from

Conversation

teto
Copy link
Member

@teto teto commented Sep 13, 2017

Motivation for this change

Upon running jupyter-console I would get
ImportError: No module named 'IPython.utils.warn'

Now I get

/nix/store/g8prw6jy2yvrww8kfmsdyzja66dbm0sl-python3-3.6.2/bin/python3.6m: No module named ipykernel_launcher
Traceback (most recent call last):
  File "/nix/store/p6h97chmra4158ph14ahabynbbyg22wn-python3.6-jupyter_console-5.1.0/lib/python3.6/site-packages/jupyter_console/ptshell.py", line 321, in init_kernel_info
    reply = self.client.get_shell_msg(timeout=1)
  File "/nix/store/qn7a9ria8s2kza9mfjaz4pa7fmrm4fjm-python3.6-jupyter_client-5.1.0/lib/python3.6/site-packages/jupyter_client/client.py", line 77, in get_shell_msg
    return self.shell_channel.get_msg(*args, **kwargs)
  File "/nix/store/qn7a9ria8s2kza9mfjaz4pa7fmrm4fjm-python3.6-jupyter_client-5.1.0/lib/python3.6/site-packages/jupyter_client/blocking/channels.py", line 57, in get_msg
    raise Empty
queue.Empty

so still a WIP

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@teto teto requested a review from FRidh as a code owner September 13, 2017 08:08
@FRidh
Copy link
Member

FRidh commented Sep 13, 2017

Thanks for reporting. I pushed 8d4e377 which seems to solve the issue and will also push this to 17.09.

@FRidh FRidh closed this Sep 13, 2017
@teto teto deleted the jupyter branch September 13, 2017 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@teto @FRidh