(pass): Add tomb plugin #29307
(pass): Add tomb plugin #29307
Conversation
|
@mickours, thanks for your PR! By analyzing the history of the files in this pull request, we identified @fpletz, @lovek323 and @the-kenny to be potential reviewers. |
pkgs/tools/security/pass/default.nix
Outdated
| { name = "update"; | ||
| rev = "cf576c9036fd18efb9ed29e0e9f811207b556fde"; sha256 = "1hhbrg6a2walrvla6q4cd3pgrqbcrf9brzjkb748735shxfn52hd"; } | ||
| { name = "tomb"; | ||
| rev = "3368134898a42c1b758fabac625ec240e125c6be"; sha256 = "0qqmxfg4w3r088qhlkhs44036mya82vjflsjjhw2hk8y0wd2i6ds"; } |
There was a problem hiding this comment.
Do all you users want these plugins? cc @fpletz
There was a problem hiding this comment.
I agree that all those plugins will probably not be used by everyone but, as there is already 2 plugins in the package, I thought that adding a third one will not hurt. Also, correct me if I am wrong, but it seems that it is not possible to add plugin afterwards, so it has to be in the pass package.
Maybe we can add an option to the package for the the user to selected the wanted plugins?
There was a problem hiding this comment.
I think they were just added by default for simplicity. But now as we get plugins with additional dependencies, it starts to make sense to rework this part.
There was a problem hiding this comment.
The proper way to do this is to add a wrapper (like vim) that then pulls in all the required runtimes.
|
I made the tomb plugin optional using |
|
Thanks! |
Motivation for this change
Add the pass-tomb plugin to pass.
Things done
Import tomb and add the tomb plugin
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)