[WIP] icinga2: init at 2.7.0 #29577

disassembler · 2017-09-19T21:12:59Z

Motivation for this change

working on adding icinga client and server to nixos.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Mic92 · 2017-09-20T01:39:12Z

pkgs/top-level/all-packages.nix

@@ -11548,6 +11548,8 @@ with pkgs;
    erlang = erlang_basho_R16B02;
  };

+  icinga2_client = callPackage ../servers/monitoring/icinga2/client.nix { };


Why not just called it icinga2 and the other package icinga2-web later?

This is how upstream names it.

peterhoeg · 2017-09-26T04:05:12Z

nixos/modules/services/monitoring/icinga2.nix

+  environment = pkgs.writeText "icinga-env" ''
+    DAEMON=${pkgs.icinga2}/sbin/icinga2
+    ICINGA2_CONFIG_FILE=/etc/icinga2/icinga2.conf
+    ICINGA2_RUN_DIR=/var/run


/var/run is deprecated - should be /run

peterhoeg · 2017-09-26T04:05:43Z

nixos/modules/services/monitoring/icinga2.nix

+  cfg = config.services.icinga2;
+  environment = pkgs.writeText "icinga-env" ''
+    DAEMON=${pkgs.icinga2}/sbin/icinga2
+    ICINGA2_CONFIG_FILE=/etc/icinga2/icinga2.conf


Any reason we "pollute" /etc? Can't we write the config to the nix store?

merely debugging trying to get the thing to run in the first place. My end goal is to have it be a src the user can define as say a git repository or tarball somewhere.

peterhoeg · 2017-09-26T04:06:13Z

nixos/modules/services/monitoring/icinga2.nix

+let
+  cfg = config.services.icinga2;
+  environment = pkgs.writeText "icinga-env" ''
+    DAEMON=${pkgs.icinga2}/sbin/icinga2


Should probably be lib.getBin pkgs.icinga2

peterhoeg · 2017-09-26T04:06:43Z

nixos/modules/services/monitoring/icinga2.nix

+    DAEMON=${pkgs.icinga2}/sbin/icinga2
+    ICINGA2_CONFIG_FILE=/etc/icinga2/icinga2.conf
+    ICINGA2_RUN_DIR=/var/run
+    ICINGA2_STATE_DIR=/var/icinga2


Should be /var/lib/icinga2 to be in line with other packages.

What does upstream here? This should be the default otherwise there is an important reason.

Most of the NixOS stuff ends up in /var/lib/[package] so if all we need to do is define that variable, shouldn't we choose to be consistent with ourselves instead of just following upstream?

Then we break documentation and third party-tools, which I find a more important aim then the aesthetics of consistency. We should always have an important reason before we break with upstream.

It's /var/lib/icinga2 on centos 7 icinga instance I have, I'm changing it here.

peterhoeg · 2017-09-26T04:07:57Z

nixos/modules/services/monitoring/icinga2.nix

+        EnvironmentFile = environment;
+        ExecStart = "${pkgs.icinga2}/bin/icinga2 daemon -d";
+        ExecReload = "${pkgs.icinga2}/lib/icinga2/safe-reload ${environment}";
+        PIDFile = "/var/run/icinga2/icinga2.pid";


You should use RuntimeDirectory = "icinga2"; to have /run/icinga2 created for you.

peterhoeg · 2017-09-26T16:01:52Z

pkgs/servers/monitoring/icinga2/default.nix

+    export MYSQL_INCLUDE_DIR=${mysql}/include/mysql
+  '';
+
+  buildInputs = [ cmake boost yajl openssl flex bison mysql postgresql ];


cmake should be in nativeBuildInputs instead. Not sure about flex and bison but probably those too.

correct, cmake, flex and bison should be there.

Mic92 · 2017-09-26T19:23:52Z

pkgs/servers/monitoring/icinga2/default.nix

+
+  preConfigure = ''
+    export MYSQL_INCLUDE_DIR=${mysql}/include/mysql
+  '';


- preConfigure = '' - export MYSQL_INCLUDE_DIR=${mysql}/include/mysql - ''; + MYSQL_INCLUDE_DIR="${mysql}/include/mysql";

disassembler · 2017-10-06T00:45:50Z

It builds successfully now, and the service runs, but running icinga2 node wizard it tries writing to ${pkgs.icinga2}/etc. This can be set using CMAKE_INSTALL_SYSCONFDIR but the install scripts do more than just create directories for that path. If anyone has any suggestions on what can be done to make this work, I'm all ears.

disassembler · 2017-10-06T20:09:23Z

Latest changes create a new variable for config directory separate from the one used that mkdir is ran using. It's a hack, but service runs, icinga2 node wizard works, and icinga2 service continued to run after restart. Next steps here are to enable database backend and create a web2 package that can be launched with a php-fpm service.

disassembler · 2018-10-27T09:25:17Z

I don't use icinga2 anymore. If someone else wants to take this over, have fun, I'm closing.

disassembler force-pushed the icinga2 branch from 6b0aeb5 to 3bd2864 Compare September 20, 2017 00:46

Mic92 reviewed Sep 20, 2017

View reviewed changes

disassembler force-pushed the icinga2 branch 3 times, most recently from 79b8388 to 143609d Compare September 20, 2017 17:39

Samuel Leathers added 2 commits September 25, 2017 11:48

icinga2: init at 2.7.0

00593d2

nixos/icinga2: add service module

c379793

peterhoeg reviewed Sep 26, 2017

View reviewed changes

icinga2: nixos service path overrides

ec6e2ea

disassembler force-pushed the icinga2 branch from 143609d to ec6e2ea Compare September 26, 2017 14:55

peterhoeg reviewed Sep 26, 2017

View reviewed changes

icinga2: cmake, flex, bison to native build inputs

551e848

Mic92 reviewed Sep 26, 2017

View reviewed changes

Samuel Leathers added 3 commits September 27, 2017 16:20

moving exports to their own variables

bfba679

icinga2: setting state and run dirs, patching to not create on install

cae301b

icinga2: more state dir directory creation removals

bb6992a

icinga2: icinga config directory hack

0ca9fbf

matthewbauer added the 2.status: work-in-progress label Mar 22, 2018

disassembler closed this Oct 27, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] icinga2: init at 2.7.0 #29577

[WIP] icinga2: init at 2.7.0 #29577

disassembler commented Sep 19, 2017 •

edited

Mic92 Sep 20, 2017

Mic92 Sep 20, 2017

peterhoeg Sep 26, 2017

peterhoeg Sep 26, 2017

disassembler Sep 26, 2017

peterhoeg Sep 26, 2017

peterhoeg Sep 26, 2017

Mic92 Sep 26, 2017

peterhoeg Sep 26, 2017

Mic92 Sep 26, 2017 •

edited

disassembler Sep 26, 2017

peterhoeg Sep 26, 2017

peterhoeg Sep 26, 2017

Mic92 Sep 26, 2017 •

edited

Mic92 Sep 26, 2017

disassembler commented Oct 6, 2017

disassembler commented Oct 6, 2017

disassembler commented Oct 27, 2018

[WIP] icinga2: init at 2.7.0 #29577

[WIP] icinga2: init at 2.7.0 #29577

Conversation

disassembler commented Sep 19, 2017 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 Sep 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 Sep 26, 2017 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

disassembler commented Oct 6, 2017

disassembler commented Oct 6, 2017

disassembler commented Oct 27, 2018

disassembler commented Sep 19, 2017 •

edited

Mic92 Sep 26, 2017 •

edited

Mic92 Sep 26, 2017 •

edited