Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

systemd-vconsole-setup: remove workaround #29576

Merged
merged 1 commit into from Sep 27, 2017
Merged

systemd-vconsole-setup: remove workaround #29576

merged 1 commit into from Sep 27, 2017

Conversation

groxxda
Copy link
Contributor

@groxxda groxxda commented Sep 19, 2017 •
edited

Motivation for this change

It's no longer needed since systemd-vconsole-setup enumerates all ttys until it finds a suitable one since systemd v234. The workaround did not work with gdm.

Should fix #22470

CC @abbradar

Things done
  • Fits CONTRIBUTING.md.
  • Tested whether running systemd-vconsole-setup without any arguments works with gdm

@groxxda
Revert "kbd service: use /dev/tty1 for systemd-vconsole-setup"
c8a8c87 
This reverts commit 0c81594.

It's no longer needed since systemd-vconsole-setup enumerates all ttys
until it finds a suitable one since systemd v234.
@joachifm joachifm added this to the 17.09 milestone Sep 20, 2017
@Mic92
Copy link
Member

Mic92 commented Sep 21, 2017

Do we need to worry about the warning? GIO_UNIMAP failed while trying to read unicode mappings: Cannot allocate memory

sudo systemctl status systemd-vconsole-setup.service
● systemd-vconsole-setup.service - Setup Virtual Console
   Loaded: loaded (/nix/store/larlcai59jzigbg0m287amrsxn3z74fl-systemd-234/example/systemd/system/systemd-vconsole-setup.service; enabled; vendor preset: enabled)
  Drop-In: /nix/store/sck3yfwz5c3c6nc3ic60mac3kczkccvy-system-units/systemd-vconsole-setup.service.d
           └─overrides.conf
   Active: inactive (dead) since Thu 2017-09-21 12:33:35 BST; 19s ago
     Docs: man:systemd-vconsole-setup.service(8)
           man:vconsole.conf(5)
  Process: 7974 ExecStart=/nix/store/larlcai59jzigbg0m287amrsxn3z74fl-systemd-234/lib/systemd/systemd-vconsole-setup (code=exited, status=0/SUCCESS)
 Main PID: 7974 (code=exited, status=0/SUCCESS)
      CPU: 58ms
Sep 21 12:33:35 turingmachine systemd[1]: Starting Setup Virtual Console...
Sep 21 12:33:35 turingmachine systemd-vconsole-setup[7974]: GIO_UNIMAP failed while trying to read unicode mappings: Cannot allocate memory
Sep 21 12:33:35 turingmachine systemd[1]: Started Setup Virtual Console.

@zimbatm
Copy link
Member

zimbatm commented Sep 23, 2017

This is not working for me. When I enabled this config my xwindow crashed. When I retried is started flashing.

@zimbatm zimbatm mentioned this pull request Sep 23, 2017
Merged
8 tasks
@fpletz fpletz merged commit 4a24420 into NixOS:master Sep 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos
Projects
None yet
Milestone
17.09
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@groxxda @Mic92 @zimbatm @joachifm @fpletz