Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alacritty: Install desktop icon #29572

Closed
wants to merge 2 commits into from
Closed

alacritty: Install desktop icon #29572

wants to merge 2 commits into from

Conversation

ttuegel
Copy link
Member

@ttuegel ttuegel commented Sep 19, 2017

Motivation

Two unrelated changes:

  • Install the .desktop file provided by alacritty
  • Run the pre- and post-hooks for overridden phases. (This is a little pedantic on my part. There are obscure errors one can get from missing hooks. None of them affect alacritty yet. I'm not sure they ever will, but I figured better to deal with it while I'm already looking at it.)

Testing

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ttuegel
alacritty: respect pre- and post-hooks of overridden phases
7174ac2 
Failing to `runHook` when overriding phases can have unpredictable results.
@ttuegel
alacritty: install desktop icon
5052909
Mic92
Mic92 reviewed Sep 19, 2017
View reviewed changes
pkgs/applications/misc/alacritty/default.nix
substituteInPlace copypasta/src/x11.rs \
--replace Command::new\(\"xclip\"\) Command::new\(\"${xclip}/bin/xclip\"\)

runHook postPatch
'';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would also put this command into postPatch so patches = [] still works.

@Mic92 Mic92 closed this in 6e01011 Sep 19, 2017
@ttuegel ttuegel deleted the alacritty branch September 20, 2017 11:09
globin pushed a commit that referenced this pull request Sep 22, 2017
@ttuegel @globin
alacritty: respect pre- and post-hooks of overridden phases
c57bf23 
Failing to `runHook` when overriding phases can have unpredictable results.

fixes #29572

(cherry picked from commit 6e01011)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@NeQuissimus NeQuissimus Awaiting requested review from NeQuissimus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ttuegel @Mic92