Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.dotfiles: 0.6.3 -> 0.6.4 #29066

Closed
wants to merge 2 commits into from
Closed

pythonPackages.dotfiles: 0.6.3 -> 0.6.4 #29066

wants to merge 2 commits into from

Conversation

tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Sep 7, 2017

Motivation for this change

upgrade minor version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@tsaeger tsaeger requested a review from FRidh as a code owner September 7, 2017 04:18
@FRidh
Copy link
Member

FRidh commented Sep 7, 2017

Thanks. This is an application, and not a Python library. Could you move the expression out of python-packages.nix.

@tsaeger
Copy link
Contributor Author

tsaeger commented Sep 7, 2017

Ok - moved 'dotfiles' out of pythonPackages as requested.

Kept the version update as separate commit.

@tsaeger
Copy link
Contributor Author

tsaeger commented Sep 8, 2017

bump

FRidh
FRidh reviewed Sep 8, 2017
View reviewed changes
pkgs/applications/misc/dotfiles/default.nix Outdated
@@ -0,0 +1,23 @@
{ stdenv, fetchurl, python27Packages }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is explicitly python27 needed, or could it also potentially work with other versions of Python? We try to stay as generic as possible, so pythonPackages has preference, but if it doesn't work with 3.x, then python2Packages (or python27Packages, that doesn't really matter anymore) should be used.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

pkgs/applications/misc/dotfiles/default.nix Outdated
license = licenses.isc;
};

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fetchPypi

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

pkgs/applications/misc/dotfiles/default.nix Outdated
sha256 = "03qis6m9r2qh00sqbgwsm883s4bj1ibwpgk86yh4l235mdw8jywv";
};

buildInputs = with python27Packages; [ pytest ];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkInputs (note that his only a Python thing)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done.

@FRidh
Copy link
Member

FRidh commented Sep 8, 2017

Thanks. Pushed e1385f0a9461a1112c74f22f37ed3d56b5620770 and also to 17.09.

@FRidh FRidh closed this Sep 8, 2017
@tsaeger
Copy link
Contributor Author

tsaeger commented Sep 8, 2017

Thanks!

FYI - I don't yet see e1385f0a9, though I see the cherry-picked commit in 17.09

@FRidh
Copy link
Member

FRidh commented Sep 8, 2017

Oh, forgot to push it. So, its d6cebc8 now.

@tsaeger tsaeger deleted the fix/dotfiles-0.6.4 branch September 9, 2017 03:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

Assignees
No one assigned
Labels
6.topic: python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tsaeger @FRidh