Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ncurses: 6.0-20170729 -> 6.0-20170902 #29065

Closed
wants to merge 1 commit into from

Conversation

tsaeger
Copy link
Contributor

@tsaeger tsaeger commented Sep 7, 2017

Layout issues in tig were noticed with previous ncurses version
within zsh with TERM=xterm-256color.

No issues were observed, under same test conditions,
with 6.0 or 6.0-20170902.

Setting TERM=screen worked for all ncurses versions listed above.

Motivation for this change

Layout issues in tig were noticed with previous ncurses version
within zsh with TERM=xterm-256color.

No issues were observed, under same test conditions,
with 6.0 or 6.0-20170902.

Setting TERM=screen worked for all ncurses versions listed above.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Layout issues in tig were noticed with previous ncurses version
within zsh with TERM=xterm-256color.

No issues were observed, under same test conditions,
with 6.0 or 6.0-20170902.

Setting TERM=screen worked for all ncurses versions listed above.
@Mic92
Copy link
Member

Mic92 commented Sep 7, 2017

Please change the target branch from master to staging, since ncurses will issue a lot of rebuilds, which we usually want to avoid happen on master first.

@vcunat vcunat changed the base branch from master to staging September 7, 2017 10:39
@vcunat
Copy link
Member

vcunat commented Sep 7, 2017

People with push access can retarget PRs themselves, though it's good to be careful if it doesn't bring unrelated commits, or do a master->staging merge before to avoid that.

@vcunat
Copy link
Member

vcunat commented Sep 7, 2017

On staging this was actually done already by @peltz fea02e3.

Note: this bump probably solves some security issues as well: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=873746 EDIT: I can only see DOS attacks on ncurses, so that doesn't sound that bad...

@vcunat vcunat closed this Sep 7, 2017
@tsaeger tsaeger deleted the fix/ncurses-20170902 branch September 29, 2017 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants