Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mfi-controller: remove #29073

Merged
merged 4 commits into from Sep 7, 2017
Merged

mfi-controller: remove #29073

merged 4 commits into from Sep 7, 2017

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Sep 7, 2017

reason: build fails in hydra
Do still need and want to maintain this @elitak?

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

reason: build fails in hydra
Do still need this and want to maintain this @elitak?
@Mic92
Copy link
Member Author

Mic92 commented Sep 7, 2017

Don't merge this, it is still referenced in nixos/modules/services/networking/mfi.nix

@Mic92
Copy link
Member Author

Mic92 commented Sep 7, 2017

Looks like there won't be any new version for mfi controller soon: https://community.ubnt.com/t5/mFi/is-MFI-dead/td-p/1388153

@Mic92 Mic92 changed the title mongodb248: remove mongodb248/mfi: remove Sep 7, 2017
@Mic92 Mic92 changed the title mongodb248/mfi: remove mfi-controller: remove Sep 7, 2017
@elitak
Copy link
Contributor

elitak commented Sep 7, 2017

I'll have look today and let you know.

@elitak
Copy link
Contributor

elitak commented Sep 7, 2017

Yeah, this is well beyond the point of salvaging; go ahead and remove them.

@Mic92 Mic92 merged commit 56ccd27 into NixOS:master Sep 7, 2017
@Mic92 Mic92 deleted the mongodb/2.4.8 branch September 7, 2017 19:31
@Mic92
Copy link
Member Author

Mic92 commented Sep 7, 2017

I suppose, you can still use a container with the old nixos release for a while.

@elitak
Copy link
Contributor

elitak commented Sep 7, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants