New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CB-244: Rating System (Docs) #150
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the schema image, on revision table text and rating rows are bold. Bold rows are ones that are not NULL-able. Is that the case with those two?
Changed text and rating rows from bold to simple fonts. |
4b9cfff
to
50dbc61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume that these modifications to the docs are related to #154? In that case they should probably merged together. It would be fine to put changes that you make here into the PR that actually changes the implementation that is being documented.
:statuscode 200: success | ||
:statuscode 400: invalid request (see source) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. No one is going to go and see the source.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Will remove it.
:json string text: Text part of review, min length is 25, max is 5000 **(optional)** | ||
:json integer rating: Rating part of review, min is 1, max is 5 **(optional)** | ||
|
||
**NOTE:** The value of unmodified parameter should be set to its value in previous revison. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't we decide that it's not going to be like that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I will update it once you confirm these changes 2b1eb37
Yes, its better. I will move the ws docs part in #154. |
OK, I'm going to close this PR. Don't forget to fix the issues that I mentioned before. |
No description provided.