Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CB-244: Rating System (Docs) #150

Closed
wants to merge 6 commits into from

Conversation

breakbuidl
Copy link
Contributor

No description provided.

Copy link
Contributor

@gentlecat gentlecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the schema image, on revision table text and rating rows are bold. Bold rows are ones that are not NULL-able. Is that the case with those two?

@breakbuidl
Copy link
Contributor Author

Changed text and rating rows from bold to simple fonts.

Copy link
Contributor

@gentlecat gentlecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume that these modifications to the docs are related to #154? In that case they should probably merged together. It would be fine to put changes that you make here into the PR that actually changes the implementation that is being documented.

:statuscode 200: success
:statuscode 400: invalid request (see source)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope. No one is going to go and see the source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Will remove it.

:json string text: Text part of review, min length is 25, max is 5000 **(optional)**
:json integer rating: Rating part of review, min is 1, max is 5 **(optional)**

**NOTE:** The value of unmodified parameter should be set to its value in previous revison.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't we decide that it's not going to be like that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I will update it once you confirm these changes 2b1eb37

@breakbuidl
Copy link
Contributor Author

It would be fine to put changes that you make here into the PR that actually changes the implementation that is being documented.

Yes, its better. I will move the ws docs part in #154.

@gentlecat
Copy link
Contributor

OK, I'm going to close this PR. Don't forget to fix the issues that I mentioned before.

@gentlecat gentlecat closed this Sep 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants