Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DEPENDENCY constant missing getter on LiveVariableAnalysis #4776

Merged

Conversation

original-brownbear
Copy link
Contributor

LiveVariableAnalysis didn't have a getDependencies method => the DEPENDENCIES constant was never used and OptimizeDynScopesPass not returned as a dependency:

  • Added the getDependencies method
  • Made DEPENDENCIES private here and in the parent to make this a little less confusing (other children of CompilerPass use the same approach => private rules out any inheritance weirdness imo :))

Also:

  • Removed dead field listeners from CompilerPass
  • Made NO_DEPENDENCIES in CompilerPass private since none of the child compiler passes use it (if they don't override getDependencies they get no dependencies => no need to use the constant in children)

@kares
Copy link
Member

kares commented Sep 5, 2017

excellent, I recall reading these, in the past, and being slightly confused as well 👍

@kares kares added this to the Non-Release milestone Sep 5, 2017
@kares kares merged commit 9b17780 into jruby:master Sep 5, 2017
@original-brownbear original-brownbear deleted the fix-dependency-LiveVariableAnalysis branch September 5, 2017 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants