Fix DEPENDENCY constant missing getter on LiveVariableAnalysis #4776
+15
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LiveVariableAnalysis
didn't have agetDependencies
method => theDEPENDENCIES
constant was never used andOptimizeDynScopesPass
not returned as a dependency:getDependencies
methodDEPENDENCIES
private
here and in the parent to make this a little less confusing (other children ofCompilerPass
use the same approach =>private
rules out any inheritance weirdness imo :))Also:
listeners
fromCompilerPass
NO_DEPENDENCIES
inCompilerPass
private since none of the child compiler passes use it (if they don't overridegetDependencies
they get no dependencies => no need to use the constant in children)