libstdc++: add setup-hook #28998
Merged
libstdc++: add setup-hook #28998
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
added
6.topic: cross-compilation
|
@LnL7, thanks for your PR! By analyzing the history of the files in this pull request, we identified @dtzWill, @copumpkin and @vcunat to be potential reviewers. |
LnL7
commented
Sep 4, 2017
| allowedRequisites = null; | ||
| cc = self.clang; | ||
| # Use the gcc libstdc++ when targeting linux. | ||
| extraBuildInputs = if targetPlatform.isLinux then [ libstdcxxHook ] else drv.extraBuildInputs; |
There was a problem hiding this comment.
perhaps this should be stdenv.cc.isGNU?
Ericson2314
approved these changes
Sep 5, 2017
LnL7
added
the
8.has: port to stable
Ericson2314
moved this from After big PR
to Needed by the big PR---nice to move pick off pieces of it and move here, rebasing the big PR on top
in Cross compilation
samueldr
removed
the
9.needs: port to stable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
An alternative for #28870, this should also allow us to get rid of
default_cxx_stdlib_compileentirelyFixes #28223
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)