Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefoxPackages: tor-browser: reorganize and update #28999

Merged
merged 4 commits into from Sep 5, 2017
Merged

firefoxPackages: tor-browser: reorganize and update #28999

merged 4 commits into from Sep 5, 2017

Conversation

oxij
Copy link
Member

@oxij oxij commented Sep 4, 2017

Motivation for this change

Update. The old version is kept because we can. Also for regression testing.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • Linux
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Seriously.
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@mention-bot
Copy link

@oxij, thanks for your PR! By analyzing the history of the files in this pull request, we identified @edolstra, @vcunat and @taku0 to be potential reviewers.

@Mic92 Mic92 requested a review from joachifm September 5, 2017 08:31
@oxij oxij changed the title firefoxPackages: tor: reorganize and update firefoxPackages: tor-browser: reorganize and update Sep 5, 2017
@joachifm joachifm merged commit 6ee01c0 into NixOS:master Sep 5, 2017
@joachifm
Copy link
Contributor

joachifm commented Sep 5, 2017

Thank you

@oxij
Copy link
Member Author

oxij commented Sep 5, 2017 via email

@oxij oxij deleted the pkg/tor-reorg-update branch March 16, 2018 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joachifm joachifm Awaiting requested review from joachifm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@oxij @mention-bot @joachifm