nginx service: enable websocket proxy support with recommendedProxySe… #28981
Conversation
…ttings This means the forwarding connection will always be HTTP/1.1 which seems reasonable these days. Further it passes allong the Upgrade header to the upstream proxy.
|
@bachp, thanks for your PR! By analyzing the history of the files in this pull request, we identified @globin, @domenkozar and @rnhmjoj to be potential reviewers. |
|
Does it really make sense to enable Websockets for every request? No webserver or proxy does this by default and the install instructions of most web applications restrict websocket configurations to specific request paths. I'll investigate some more before deciding to merging this. We have this commit in our fork which would be an alternative if passing the Upgrade header by default isn't safe. |
|
@fpletz Addint this as an additional option similar to your fork would also be nice. I just think it should be easier to enable websocket proxying than it is right now. |
|
This is already solved by 65c2203 |
|
Oh, @globin already pushed it to master. Great if that version works for you. I've done some research but haven't found any good information about possible security implications. |
|
@fpletz Your commit does exactly what I intended (except better). Works perfectly fine thanks. |
Motivation for this change
Enable websocket support when
recommendedProxySettings = true;This means the forwarding connection will always be HTTP/1.1 which seems
reasonable these days.
Further it passes allong the Upgrade header to the upstream proxy.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)