Revert "Network: fix a concurrency problem, by re-adding a copy in ConnectionCommand"

nerzhul · nerzhul · commit 31e0f0efe93a · 2017-09-04T17:28:29.000+02:00
This reverts commit 5b04f5e.
diff --git a/src/network/connection.h b/src/network/connection.h
@@ -330,18 +330,6 @@ struct ConnectionCommand
 	bool raw = false;
 
 	ConnectionCommand() = default;
-	ConnectionCommand &operator=(const ConnectionCommand &other)
-	{
-		type = other.type;
-		address = other.address;
-		peer_id = other.peer_id;
-		channelnum = other.channelnum;
-		// We must copy the buffer here to prevent race condition
-		data = SharedBuffer<u8>(*other.data, other.data.getSize());
-		reliable = other.reliable;
-		raw = other.reliable;
-		return *this;
-	}
 
 	void serve(Address address_)
 	{
