Network: fix a concurrency problem, by re-adding a copy in Connection…

…Command
minetest · Sep 4, 2017 · 5b04f5e · t0ny2 · Sep 4, 2017 · nerzhul
1 parent a383eb0
commit 5b04f5e
Showing 1 changed file with 12 additions and 0 deletions.
diff --git a/src/network/connection.h b/src/network/connection.h
@@ -330,6 +330,18 @@ struct ConnectionCommand
 	bool raw = false;
 
 	ConnectionCommand() = default;
+	ConnectionCommand &operator=(const ConnectionCommand &other)
+	{
+		type = other.type;
+		address = other.address;
+		peer_id = other.peer_id;
+		channelnum = other.channelnum;
+		// We must copy the buffer here to prevent race condition
+		data = SharedBuffer<u8>(*other.data, other.data.getSize());
+		reliable = other.reliable;
+		raw = other.reliable;
+		return *this;
+	}
 
 	void serve(Address address_)
 	{