Tensorflow1.3 dependencies #28530
Tensorflow1.3 dependencies #28530
Conversation
jyp
force-pushed
the
tensorflow1.3-dependencies
branch
from
d4aadb6
to
d831b65
Compare
pkgs/top-level/python-packages.nix
Outdated
| @@ -2089,6 +2089,8 @@ in { | |||
|
|
|||
| httpserver = callPackage ../development/python-modules/httpserver {}; | |||
|
|
|||
| bleach1_5 = callPackage ../development/python-modules/bleach/1.5.nix {}; | |||
There was a problem hiding this comment.
we keep only one version of a package, not more. What do you need it for?
There was a problem hiding this comment.
This is a "tensorflow-tensorboard" dependency. Perhaps we won't need it if we decide to drop tensorboard, see my comment on the PR.
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| name = "${pname}-${version}"; |
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| pname = "bleach"; |
| description = "NVIDIA CUDA Deep Neural Network library (cuDNN)"; | ||
| homepage = https://developer.nvidia.com/cudnn; | ||
| license = stdenv.lib.licenses.unfree; | ||
| maintainers = with maintainers; [ mdaiter ]; |
There was a problem hiding this comment.
If you mean the license, nvidia states: "If the SOFTWARE is provided in source form, Licensee may not modify or create derivative works of the SOFTWARE." So I'd say definitely unfree.
If you mean the maintainer then I have no opinion.
There was a problem hiding this comment.
The maintainer. You add a new expression (I suppose you copied it) adding someone else as maintainer. You've asked the person whether they're willing to maintain this expression?
Reviewers: please advise as how to deal with such a circular dependency between python packages. The manual https://nixos.org/nixpkgs/manual/#how-to-solve-circular-dependencies prescribe to override the packages to remove the offending dependency however it is silent on how this should be done.
In case of the former, it typically means overriding the |
|
Regarding the circular dependency: tensorflow and tensorboard are provided as wheels. I found a workaround though: one can supply But then again, I cannot install both tensorflow and tensorboard because of the following collision: Tensorflow is still usable without tensorboard, so I would propose to not install tensorboard for the time being. |
jyp
force-pushed
the
tensorflow1.3-dependencies
branch
from
bfdcdc2
to
c7555dd
Compare
|
@FRidh |
jyp
force-pushed
the
tensorflow1.3-dependencies
branch
from
c7555dd
to
a4f836c
Compare
|
@jyp if it checks for dependencies then its likely that it is also needed during runtime. Have you checked upstream what they say about requiring bleach? |
|
@FRidh I don't think I made myself so clear :) I'm thinking to remove tensorboard from the dependencies of tensorflow (core). Tensorboard is the visualization engine of tensorflow. According to my tests it isn't required to run tensorflow models --- only to visualize the results. So as far as I understand tensorboard is not a necessary component and should be dropped from the dependencies of tensorflow --- even upstream. Now, we have then the opportunity to remove tensorboard entirely from nixpkgs; and in turn its dependencies, including bleach 1.5. |
jyp
force-pushed
the
tensorflow1.3-dependencies
branch
from
a4f836c
to
a8afe3a
Compare
jyp
force-pushed
the
tensorflow1.3-dependencies
branch
from
a8afe3a
to
e8a20fb
Compare
|
@FRidh Do you think that this PR could be accepted in the current state? I've dropped the extra bleach version. What remains is I believe rather uncontroversial:
|
|
I've added these commits to #29009. |
Motivation for this change
This branch prepares for tensorflow 1.3 by adding the necessary dependencies.
Unfortunately, this branch does not add tensorflow 1.3 itself because of a circular dependency between tensorflow and tensorflow_tensorboard.
Reviewers: please advise as how to deal with such a circular dependency between python packages. The manual https://nixos.org/nixpkgs/manual/#how-to-solve-circular-dependencies prescribe to override the packages to remove the offending dependency however it is silent on how this should be done.
Things done
(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)