Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RN_Soviet Probes #1771

Closed
wants to merge 143 commits into from
Closed

RN_Soviet Probes #1771

wants to merge 143 commits into from

Conversation

DocRockwell
Copy link
Contributor

@DocRockwell DocRockwell commented Aug 28, 2017

Request:
-increase antenna range for Luna 1 and Luna 3 probes for lunar use. Current extended range is 1.9 Mm, suggest an increase to 4.0 Mm to match the communitron 16 antenna.

-decrease energy cost of antenna on Pioneer 5 probe from 0.15 to 0.0015, bringing it in line with Communitron 32. Currently the Pioneer 5's solar panels can't come close to keeping up with the power drain.

AnticlockwisePropeller and others added 30 commits May 26, 2017 19:29
Fixed stats, fixed Able scale, changed AbleStar to use rescaleFactor for scaling, removed unnecessary PartStatsUpgradeModules
Create RO-RealPlume cfg for Able engine (AJ10 Early)
Create RO-RealPlume cfg for AbleStar engine (AJ10 Mid)
Change scaling on Able (AJ10 Early) so nozzle diameter is correct (~0.6m). Original scaling had been based on shroud diameter
minor plume tweaks
remove sneaky newline
-Remove reflection from parts that shouldn't have it
The S-3 unlocks with the parts, the S-3D is an upgrade so needs an
entryCost instead of the S-3
Somehow I had missed the M-1-Spec config, this updates the PARTUPGRADES
to fit into the right nodes.
* Changed the RL10 entryCostModifiers to use actual values to stay in
line with how all other configs are created
* Renamed XLR81_Config to Agena_XLR81_Config since the name of the
engine in config files is Agena (this helps when working down a list
alphabetically)
This makes sense in terms of unlocks as the Vulcain unlocks first. This
makes the configs act like all other engines.
* Renamed the Config names to match with @raidernick parts oer
discussions with @NathanKell et al
* Added 5 new configs for both RD-107 and RD-108
* Added descriptions for all configs in order to tell the player what LV
the engines were used on

RD-107 Configs
*RD-107-8D74
*RD-107-8D74PS
*RD-107-8D74-1958
*RD-107-8D76
*RD-107-8D74-1959
*RD-107-8D74K
*RD-107-8D728
*RD-107-11D511
*RD-107-11D511P
*RD-107A-14D22

RD-108 Configs
*RD-108-8D75
*RD-108-8475PS
*RD-108-8D75-1958
*RD-108-8D77
*RD-108-8D75-1959
*RD-108-8D75K
*RD-108-8D727
*RD-108-11D512
*RD-108-11D512P
*RD-108A-14D21
Removed all PARTUPGRADE features in the Engine Configs. They are moving
to RP-0.
@raidernick
Copy link
Contributor

raidernick commented Mar 18, 2018

So what is going on with this PR? If this gets merged it's going to revert a ton of changes and cause massive problems. It should be closed and resubmitted.

Also why is this being set to merge from the ro dev branch into master? When the time comes the dev branch will just be merged into the master, so why is this PR set to do that is it a mistake? Is this not a normal pr submitted to make some fixes to antennae how did it end up like this?

Schnobs and others added 2 commits March 18, 2018 19:08
The supposedly exterior nodes were deep inside.
Mk1 Cargo Bay (2m) attachment nodes fix
@blowfishpro
Copy link
Member

@DocRockwell this should be rebased against the latest master/dev ... it can't be merged as it is

@raidernick
Copy link
Contributor

After discussing this in IRC we decided that it's not worth trying to rebase, it should be closed and you will need to resubmit it using a branch that is even with dev beforehand.

@raidernick raidernick closed this Mar 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet