New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create redistribution archive for successful builds #2864
Conversation
hkaiser
commented
Aug 27, 2017
- flyby: export HPX_VERSION_STRING from HPXConfig.cmake
- flyby: export HPX_VERSION_STRING from HPXConfig.cmake
c4e7e86
to
023f38f
Compare
host: ftp.stellar-group.org | ||
username: appveyor-ci@stellar-group.org | ||
password: | ||
secure: tsfxuDuvSntD/aqRcuxSvkU4lqQck85OI7e7nhDhIr4= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure you want to store that at such a prominent spot?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the correct way of storing sensitive data in appveyor: https://www.appveyor.com/docs/how-to/secure-files/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sithhell this is encrypted, so it's safe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So I can't just copy the credentials and use them to store stuff on the ftp?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, got it.
|
||
test_script: | ||
- cmd: | | ||
set PATH=%PATH%;C:\projects\vcpkg\installed\x64-windows\debug\bin | ||
python build\bin\hpxrun.py -l2 -t2 build\Debug\bin\hello_world.exe -- --hpx:bind=none | ||
|
||
artifacts: | ||
- path: hpx-master-redist-$(MSVC_GENERATOR_SHORT)-$(configuration).7z |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What information does the configuration contain?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sithhell 'Debug', 'Release', etc. It's essentially the CMAKE_BUILD_TYPE
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok. Does it make sense to add the commit hash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I intentionally didn't do that. All I need is the snapshot from the latest successful build. Similar to what we do in CircleCI.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks.