Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create redistribution archive for successful builds #2864

Merged
merged 1 commit into from Aug 29, 2017

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Aug 27, 2017

  • flyby: export HPX_VERSION_STRING from HPXConfig.cmake

- flyby: export HPX_VERSION_STRING from HPXConfig.cmake
host: ftp.stellar-group.org
username: appveyor-ci@stellar-group.org
password:
secure: tsfxuDuvSntD/aqRcuxSvkU4lqQck85OI7e7nhDhIr4=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure you want to store that at such a prominent spot?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is the correct way of storing sensitive data in appveyor: https://www.appveyor.com/docs/how-to/secure-files/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sithhell this is encrypted, so it's safe

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I can't just copy the credentials and use them to store stuff on the ftp?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, got it.


test_script:
- cmd: |
set PATH=%PATH%;C:\projects\vcpkg\installed\x64-windows\debug\bin
python build\bin\hpxrun.py -l2 -t2 build\Debug\bin\hello_world.exe -- --hpx:bind=none

artifacts:
- path: hpx-master-redist-$(MSVC_GENERATOR_SHORT)-$(configuration).7z
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What information does the configuration contain?

Copy link
Member Author

@hkaiser hkaiser Aug 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sithhell 'Debug', 'Release', etc. It's essentially the CMAKE_BUILD_TYPE.

Copy link
Member

@sithhell sithhell Aug 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Does it make sense to add the commit hash?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I intentionally didn't do that. All I need is the snapshot from the latest successful build. Similar to what we do in CircleCI.

Copy link
Member

@sithhell sithhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@sithhell sithhell merged commit 6cef4d0 into master Aug 29, 2017
@sithhell sithhell deleted the appveyor-artifact branch August 29, 2017 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants