Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ab0eccd21350
Choose a base ref
...
head repository: smoltcp-rs/smoltcp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8ae9b21b64e3
Choose a head ref
  • 3 commits
  • 6 files changed
  • 1 contributor

Commits on Aug 28, 2017

  1. Get rid of unused arguments in Socket::{process,dispatch}. 

    I've left those "for consistency" but it just implies data
dependencies where there are none, and bloats signatures.
    @whitequark
    whitequark committed Aug 28, 2017
    Copy the full SHA
    3974dc7 View commit details

  2. Factor out packet parsing from Socket::process. 

    Not only is it incredibly wasteful, but this information is
in any case already necessary within the EthernetInterface::process_*
methods.
    @whitequark
    whitequark committed Aug 28, 2017
    Copy the full SHA
    43a547f View commit details

  3. Break up the EthernetInterface::dispatch macro atrocity into functions. 

    There wasn't any real reason for it to be a macro, it was ugly
and unreadable, and it resulted in combinatorial bloat when compiled.
    @whitequark
    whitequark committed Aug 28, 2017
    Copy the full SHA
    8ae9b21 View commit details
Loading