Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broadcast IP resolving shouldn't happen via ARP cache #33

Closed
steffengy opened this issue Aug 27, 2017 · 1 comment
Closed

Broadcast IP resolving shouldn't happen via ARP cache #33

steffengy opened this issue Aug 27, 2017 · 1 comment

Comments

@steffengy
Copy link
Contributor

steffengy commented Aug 27, 2017 •
edited
Loading

When sending an UDP broadcast packet via an UdpSocket,
I noticed that smoltcp attempted to check the ArpCache for 255.255.255.255
and therefore send an ARP request for that IP, which I believe to be unusual.

I think insteadof calling ArpCache::lookup a general lookup-function
should be called, which handles this (255.255.255.255 to MAC [0xff; 6] ) aswell
as other possible exceptions in the future.

Does that sound like the right approach?
I'd be fine with implementing it, but wanted some feedback first.
@whitequark
Copy link
Contributor

Fixed as a side effect of 8ae9b21.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@whitequark @steffengy