Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NTR fixing, and RD-108 #1770

Closed
wants to merge 3 commits into from
Closed

NTR fixing, and RD-108 #1770

wants to merge 3 commits into from

Conversation

Bornholio
Copy link
Contributor

did something before that shifted some {}
noticed RD108 was missing module

took time to make changes to clean the files up, begin figuring out TF configs
Needs corrected OrigMass!
needs a corrected origMass and configuration name
@@ -47,7 +47,7 @@
{
name = ModuleEngineConfigs
type = ModuleEngines
origMass = 1.19 // Needs correct origMass Value
origMass = 1.278 // Needs verify origMass Value (value taken from VSR)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mass value is invalid. The VSR RD-108 engine differs from the base global engine config since:

  • It has integrated vernier engines (more mass).
  • It has integrated structural fairing around the actual engine (more mass).
  • The inert mass values of all the RD-108 engine variants are known from the sources listed at the top of the config file.

I do not know why this comment was there, probably a leftover...

Copy link
Contributor Author

@Bornholio Bornholio Aug 27, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added those since i was trying to repair it without reference. Right now its broken. (not able to be config'd)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are missing a closing bracket at line No. 574: https://github.com/Bornholio/RealismOverhaul/blob/32ba1e8f21606af31dbd9256b3d541a0b654253c/GameData/RealismOverhaul/Engine_Configs/RD108_RD118_Config.cfg#L574

For some reason you reported that as an issue and it got removed: https://github.com/KSP-RO/RealismOverhaul/pull/1767/files. But if you take a closer look it is obvious that the bracket is actually missing (extra brackets are ignored by KSP).

I'd suggest Notepad++ as an editor. You can directly see where the brackets are opening and closing very easily.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks, yeah that was me rushing a fix, and not noticing that at some point the whole module disappeared. I don't normally use the Russian engines. I'll see if something In paps spreadsheet doing ECM fixing is mangling the configs once I can talk with him.

@Bornholio Bornholio closed this Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants