ngrok: 1.7.1 -> 2.2.8, added ngrok1 1.1.7 #28623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ngrok now releases a proprietary version (2.x). 1.1.7 can still be used with a self-hosted ngrokd, but it won't work out of the box. Therefore ngrok 2.2.8 is now the default for the `ngrok` package and ngrok 1.1.7 can be installed using the `ngrok1` package.
bobvanderlinden
force-pushed
the
pr-ngrok2
branch
from
1a65682
to
8967da9
Compare
bobvanderlinden
force-pushed
the
pr-ngrok2
branch
from
8967da9
to
72ff233
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
ngrok now releases a proprietary binary version (2.x). 1.1.7 can still be used
with a self-hosted ngrokd, but it won't work out of the box.
Therefore ngrok 2.2.8 is now the default for the
ngrokpackage andngrok 1.1.7 can be installed using the
ngrok1package.This is related to #24612
Things done
ngroktongrok1ngrokpackage versioned 2.2.8 and set the license tounfree.(nix.useSandbox on NixOS,
or option
build-use-sandboxinnix.confon non-NixOS)
nix-shell -p nox --run "nox-review wip"./result/bin/)@matthiasbeyer, you suggested to rename the package and add a warning. At the moment I've changed the license, is that the proper way of giving users a warning?