Skip to content

TCP reset generation is not quite correct #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
whitequark opened this issue Jun 26, 2017 · 1 comment
Closed

TCP reset generation is not quite correct #20

whitequark opened this issue Jun 26, 2017 · 1 comment
Labels
kind/bug

Comments

@whitequark
Copy link
Contributor

From RFC 793:

If the incoming segment has an ACK field, the reset takes its
sequence number from the ACK field of the segment, otherwise the
reset has sequence number zero and the ACK field is set to the sum
of the sequence number and segment length of the incoming segment.

We take small liberties with ACK handling but we shouldn't.
@whitequark
Copy link
Contributor Author

Fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug
Milestone
No milestone
Development

No branches or pull requests
1 participant
@whitequark