Add behave #28628

alunduil · 2017-08-28T03:13:18Z

Motivation for this change

Adding package for behave. Please, let me know if I missed anything. I think I understood the examples and documentation correctly but would love to know any tips as well.

Things done

Tested using sandboxing
(nix.useSandbox on NixOS,
or option build-use-sandbox in nix.conf
on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- Linux
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh

I've added some comments to one expression. They apply to the other expressions as well. Please fix that.

FRidh · 2017-08-28T07:14:14Z

pkgs/development/python-modules/behave/default.nix

+  nativeBuildInputs = [ mock nose pyhamcrest strace ];
+  propagatedBuildInputs = [ glibcLocales parse parse-type six ];
+
+  patchPhase = ''


FRidh · 2017-08-28T07:14:26Z

pkgs/development/python-modules/behave/default.nix

+  propagatedBuildInputs = [ glibcLocales parse parse-type six ];
+
+  patchPhase = ''
+  # Fix `bin/behave` shebang …


indentation

FRidh · 2017-08-28T07:14:31Z

pkgs/development/python-modules/behave/default.nix

+  doCheck = true;
+
+  checkPhase = ''
+  export LANG="en_US.UTF-8"


indentation

FRidh · 2017-08-28T07:14:46Z

pkgs/development/python-modules/behave/default.nix

+  version = "1.2.5";
+  name = "${pname}-${version}";
+
+  src = fetchurl {


FRidh · 2017-08-28T07:15:09Z

pkgs/development/python-modules/behave/default.nix

+  };
+
+  nativeBuildInputs = [ mock nose pyhamcrest strace ];
+  propagatedBuildInputs = [ glibcLocales parse parse-type six ];


glibcLocales should not be propagated

FRidh · 2017-08-28T07:15:27Z

pkgs/development/python-modules/behave/default.nix

+    sha256 = "81b731ac5187e31e4aad2594944fa914943683a9818320846d037c5ebd6d5d0b";
+  };
+
+  nativeBuildInputs = [ mock nose pyhamcrest strace ];


test runner requirements can be added to checkInputs

FRidh · 2017-08-28T07:16:13Z

pkgs/development/python-modules/pytest-runner/default.nix

@@ -0,0 +1,27 @@
+{ stdenv, fetchurl


we already have pytestrunner

alunduil · 2017-08-28T23:45:35Z

Thanks! I didn't know if fetchPypi was kosher and the indentation stuff makes sense. I completely missed pytestrunner. Thanks for pointing these out. I've rebased my fixes for these issues into their respective commits. Let me know if anything else looks amiss.

alunduil · 2017-08-29T03:13:33Z

I've cleaned up an issue I found with the licenses but I'm not sure how to handle the license for parse (it only indicates the license through the pypi classifiers as BSD). I've currently set the parse license to all BSD licenses but this doesn't feel correct. Can you let me know what the best case would be for this?

Mic92 · 2017-08-29T07:15:25Z

pkgs/top-level/python-packages.nix

+
+  parse-type = callPackage ../development/python-modules/parse-type { };
+
+  pytest-runner = callPackage ../development/python-modules/pytest-runner { };


You forget to remove this line.

Mic92 · 2017-08-29T07:16:10Z

pkgs/development/python-modules/behave/default.nix

+
+  postPatch = ''
+    # Fix `bin/behave` shebang …
+    sed -e "1s@/usr/bin/env python@${python.interpreter}@" -i bin/behave


use patchShebangs here

Mic92 · 2017-08-29T07:17:18Z

pkgs/development/python-modules/parse/default.nix

+  ];
+
+  checkPhase = ''
+    ${python.interpreter} test_parse.py


@FRidh is there actually a reason ${python.interpreter} is used all over the place in python-modules instead of just python which should be in PATH?

Yes, because we have different interpreters, like python3 (which nowadays have a symlink from python) and pypy.

Are there cases where both interpreters end up in buildPythonPackage?

I hope not because then we would have issues also with PYTHONPATH.

In the end you need to be able to write python test_parse.py or pypy test_parse.py so I don't see any other way than using a variable like that here.

FRidh · 2017-08-29T07:44:53Z

The license can be found in the footer of the Python files, e.g.
https://github.com/r1chardj0n3s/parse/blob/master/test_parse.py#L797
I don't know what license this is. Its not a BSD license, although it does seem to be inspired by the original BSD license.

FRidh · 2017-08-29T07:53:51Z

pkgs/development/python-modules/parse-type/default.nix

+  };
+
+  patches = [
+    (fetchpatch {


what is this patch for? Can you include a comment.

Oh, nevermind, the patch name clarifies it.

alunduil · 2017-08-29T22:50:12Z

I think I got the latest batch of finds. Let me know if there is anything else that looks amiss and I'll keep my eye on the travis run. Thanks for all the suggestions so far.

alunduil · 2017-09-02T14:48:52Z

Does anyone have any suggestions on how to get the last test on travis to succeed? Also, are there any other suggestions blocking this merge?

FRidh · 2017-09-06T14:00:24Z

Thank you. Added it to #29009.

alunduil requested a review from FRidh as a code owner August 28, 2017 03:13

FRidh requested changes Aug 28, 2017

View reviewed changes

FRidh added 6.topic: python 8.has: package (new) labels Aug 28, 2017

Mic92 reviewed Aug 29, 2017

View reviewed changes

FRidh reviewed Aug 29, 2017

View reviewed changes

Alex Brandt added 4 commits September 2, 2017 10:48

pythonPackages.parse: init at 1.6.6

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Learn about vigilant mode

04de78e

pythonPackages.pyhamcrest: init at 1.9.0

1c7bb91

pythonPackages.parse-type: init at 0.3.4

55c7ee0

behave: init at 1.2.5

a11c72c

FRidh closed this Sep 6, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add behave #28628

Add behave #28628

alunduil commented Aug 28, 2017 •

edited

Loading

FRidh left a comment •

edited

Loading

FRidh Aug 28, 2017

FRidh Aug 28, 2017

FRidh Aug 28, 2017

FRidh Aug 28, 2017

FRidh Aug 28, 2017

FRidh Aug 28, 2017

FRidh Aug 28, 2017

alunduil commented Aug 28, 2017

alunduil commented Aug 29, 2017

Mic92 Aug 29, 2017

Mic92 Aug 29, 2017

Mic92 Aug 29, 2017

FRidh Aug 29, 2017

Mic92 Aug 29, 2017 •

edited

Loading

FRidh Aug 29, 2017

FRidh commented Aug 29, 2017

FRidh Aug 29, 2017

FRidh Aug 29, 2017 •

edited

Loading

alunduil commented Aug 29, 2017

alunduil commented Sep 2, 2017

FRidh commented Sep 6, 2017


		parse-type = callPackage ../development/python-modules/parse-type { };

		pytest-runner = callPackage ../development/python-modules/pytest-runner { };

Add behave #28628

Add behave #28628

Conversation

alunduil commented Aug 28, 2017 • edited Loading

Motivation for this change

Things done

FRidh left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alunduil commented Aug 28, 2017

alunduil commented Aug 29, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Mic92 Aug 29, 2017 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

FRidh commented Aug 29, 2017

Choose a reason for hiding this comment

FRidh Aug 29, 2017 • edited Loading

Choose a reason for hiding this comment

alunduil commented Aug 29, 2017

alunduil commented Sep 2, 2017

FRidh commented Sep 6, 2017

alunduil commented Aug 28, 2017 •

edited

Loading

FRidh left a comment •

edited

Loading

Mic92 Aug 29, 2017 •

edited

Loading

FRidh Aug 29, 2017 •

edited

Loading