tigervnc: correct default ssh client path #29084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The -via command sets up an ssh tunnel, but is hardcoded to /usr/bin/ssh upstream. This patches it to use the nixpkgs openssh client.
LnL7
suggested changes
Sep 8, 2017
| @@ -91,6 +91,11 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| enableParallelBuilding = true; | |||
|
|
|||
| postPatch = '' | |||
There was a problem hiding this comment.
The patchPhase is overridden, so the post hook won't get executed.
|
here we go! |
fpletz
pushed a commit
that referenced
this pull request
Sep 10, 2017
* tigervnc: correct default ssh client path The -via command sets up an ssh tunnel, but is hardcoded to /usr/bin/ssh upstream. This patches it to use the nixpkgs openssh client. * tigervnc: patch ssh path correctly (cherry picked from commit e9183fd)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The -via command sets up an ssh tunnel, but is hardcoded to /usr/bin/ssh
upstream. This patches it to use the nixpkgs openssh client.
Motivation for this change
Currently the -via command does not work without manually setting the VNC_VIA_CMD environment variable
Fixes #29003
CC @viric
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)