vaultenv: init at 0.5.0 #29089
Merged
vaultenv: init at 0.5.0 #29089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peti
requested changes
Sep 9, 2017
pkgs/top-level/all-packages.nix
Outdated
| @@ -19114,6 +19114,8 @@ with pkgs; | |||
|
|
|||
| vault = callPackage ../tools/security/vault { }; | |||
|
|
|||
| vaultenv = callPackage ../tools/security/vaultenv { }; | |||
There was a problem hiding this comment.
Haskell packages need to be registered in pkgs/development/haskell-modules/configuration-common.nix instead. Look for tinc in that file for an example of how this is done. You'll find it's actually easier than the construct you've used now.
|
Anything left to do here? |
peti
approved these changes
Sep 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Not sure what the preferred way is to add haskell packages like this that are not on hackage.
/cc @peti
Things done
build-use-sandboxinnix.confon non-NixOS)./result/bin/)